Fixed Windows tests

The release fixes some common Windows test issues, namely:

     NoMethodError:
       undefined method `symlink?' for Puppet::Util::Windows::File:Module
     # ./spec/fixtures/modules/acl/lib/puppet/provider/acl/windows.rb:58:in `validate'
     # ./spec/fixtures/modules/acl/lib/puppet/type/acl.rb:376:in `block (2 levels) in <top (required)>'
     # ./.bundle/ruby/2.5.0/gems/puppet-5.3.2/lib/puppet/type.rb:2398:in `initialize'
     # ./spec/fixtures/modules/acl/lib/puppet/type/acl.rb:115:in `initialize'
     # ./.bundle/ruby/2.5.0/gems/puppet-5.3.2/lib/puppet/resource.rb:460:in `new'
     # ./.bundle/ruby/2.5.0/gems/puppet-5.3.2/lib/puppet/resource.rb:460:in `to_ral'
     # ./.bundle/ruby/2.5.0/gems/puppet-5.3.2/lib/puppet/resource/catalog.rb:625:in `block in to_catalog'
     # ./.bundle/ruby/2.5.0/gems/puppet-5.3.2/lib/puppet/resource/catalog.rb:617:in `each'
     # ./.bundle/ruby/2.5.0/gems/puppet-5.3.2/lib/puppet/resource/catalog.rb:617:in `to_catalog'
     # ./.bundle/ruby/2.5.0/gems/puppet-5.3.2/lib/puppet/resource/catalog.rb:498:in `to_ral'
     # ./.bundle/ruby/2.5.0/gems/rspec-puppet-2.6.11/lib/rspec-puppet/matchers/compile.rb:142:in `cycles_found?'
     # ./.bundle/ruby/2.5.0/gems/rspec-puppet-2.6.11/lib/rspec-puppet/matchers/compile.rb:25:in `matches?'
     # ./spec/classes/role/sqlserver_spec.rb:55:in `block (5 levels) in <top (required)>'

and #269

undefined method `name_to_principal' for Puppet::Util::Windows::SID:Module

Added Ubuntu 18.04 x64 facts

New Features:

• Added Ubuntu 18.04 x64 facts

Bugfixes:

• Docs

Allow r10k config & remove Puppet 4 compatability

Fixing tests required a new version of rubocop, which required a new version of Ruby , which Puppet 4 doesn't support. Puppet 4 has been out of support for ages and I think the time has come to drop it.

New Features:

• R10k confic can be created in the root or in spec/r10k.yaml and it will be respected

Removals:

• Puppet 4

Lock Facter < 4

As per #258 there seem to be issues with Facter 4. Requiring a lower version until these are fixed

Cri bugfix

• Fixed #255

Move to RSpec mocks

This finally removed as requested in #210. This might break things for people but it's probably unlikely so not going to do a major release

Added handling of bad execs

This release adds handling of bad command execs by default. The details are in #236

Removed hard dependency on json

Onceover now uses multi_json which means that we no longer need the C JSON gem, we can use a native version meaning that we don't need to compile anything! This will likely have some performance impact but very, very minor. If you want to switch back just include the json gem in your bundle and multi_json will select that as it's faster

Fixed formatting

This adds the factset name to the output finally #231

It also fixes an untracked bug where output would hide errors when running in parallel

Many bugfixes

This release fixes the following bugs:

• vendor dir was synced which took ages and isn't required. #225
• Repos without Puppetfiles are now handled, no need to have a blank Puppetfile #223
• Factsets with an environment fact now have it ignored #227
• Escape characters are now correctly handled in pre_conditions #224