-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HowlConstructor.value is not a constructor error #29
Conversation
Do you know if this also fixes the same error for nuxt 3 with auto importing and constructor? I think they are related issues. |
Sorry I have not used nuxt so can't say for sure. |
I'm not using Simply importing those import { computed, shallowRef, ref, watch, onMounted, nextTick } from 'vue'
import { useSound } from '@vueuse/sound' I've tried export default defineConfig({
optimizeDeps: {
exclude: ['@vueuse/sound'],
},
}) but no success so far. Not sure if your PR will fix the issue here. Nothing really fancy configuration-wise.
|
@kissu did you try
? Also I generally recognise that this PR is not ideal. It sounds like vue-demi needs to be updated but that's beyond my expertise |
Please merge, thank you. |
+1 |
No point into spamming tbh. @AtlasApollo @SuzyWeightman |
You're right, I apologize for that. |
@P-James This issue gets resolved from your |
Will this PR fix this error or not? If it does, I'd like to kindly request that this PR gets merged; thanks in advance :) |
Yes! |
Hello here :) Sorry for late answer, a bit overwhelmed lately, preparing conferences! Happy to get your feedbacks if this fixes all of your issues. @kissu @P-James @Koaieus @ThimoDEV ; could you let me know what is that issue with Nuxt 3 exactly? The demo website does run on Nuxt and I have no types problems there. |
@Tahul I believe it's related to this issue #30, the reason that the demo website runs fine might be because it is not using vueuse/sound as a package, but importing the module directly from the src repo so it is able to find the file, whereas as a downloaded package, for some reason it cannot find the module |
First off there seems to be a missing dependency for Secondly there seems to be a nesting problem with the nuxt config where it says I was just about to get to testing the new version but time is up for today so tomorrow I will report more! |
@Koaieus ; thanks so much for giving some context. Going to fix these issues very soon. |
Now i'm getting ...
|
@louia I have the same issue. Have you found any workaround for this?
|
I had to make 2 changes to get the package working in a fresh Vite CLI app (vue 3).
2a. Either import onMounted from 'vue' instead of 'vue-demi' (as mentioned here Not working with Vue3 & Vite3 #27 (comment))
2b. Or add the vite config option to disable pre-bundling of vue-demi in my own app.
I thought 2b was the better option.
Only tested on a Vite CLI app.