Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Automatically install vyper version specified in version pragma #9

Open
spinoch opened this issue Feb 18, 2021 · 6 comments
Open

Automatically install vyper version specified in version pragma #9

spinoch opened this issue Feb 18, 2021 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@spinoch
Copy link
Contributor

spinoch commented Feb 18, 2021

As a user, I want blackadder to automatically fetch and install the vyper version specified in my vyper file so that it can format the file.

Brownie implements this functionality here https://github.com/eth-brownie/brownie/blob/a88888a8724c0e99085502b7ae8ded835a2b0934/brownie/project/compiler/vyper.py

@spinoch spinoch added the help wanted Extra attention is needed label Feb 18, 2021
@spinoch
Copy link
Contributor Author

spinoch commented Feb 18, 2021

This is causing the red builds at the moment

@iamdefinitelyahuman
Copy link

Brownie accomplishes this via a package called vvm - https://github.com/vyperlang/vvm

@spinoch
Copy link
Contributor Author

spinoch commented Feb 22, 2021

Kind of blocked by vyperlang/vvm#5 atm

@spinoch
Copy link
Contributor Author

spinoch commented Feb 24, 2021

Created this without thinking about the issue too much: it makes more sense if we make blackadder parse the AST even if the vyper version installed is different than the version specified in pragma (at least, if the major version is the same). Will phrase this in another issue

@spinoch spinoch closed this as completed Feb 24, 2021
@spinoch
Copy link
Contributor Author

spinoch commented Mar 24, 2021

@iamdefinitelyahuman what would you think about isolating the logic of brownie's brownie.compiler.vyper.find.*vyper_version?
I think it makes sense to use that same logic in blackadder, but I don't think it makes sense to have brownie as a dependency.
Maybe putting it in vvm.utils could work for both brownie and blackadder

@spinoch spinoch reopened this Mar 24, 2021
@iamdefinitelyahuman
Copy link

I think it could live in vvm.utils without hurting anybody too much :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants