Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-borders-4] naming of the "not curved" (90deg convex) keyword for corner-shape #11607

Open
noamr opened this issue Jan 30, 2025 · 2 comments

Comments

@noamr
Copy link
Collaborator

noamr commented Jan 30, 2025

Following up on #10993

When the corner shape is a fully convex angle (as in, it's not curved at all, superellipse(infinity)), we resolved on referring to it as none.
I think a better name for this is straight. It's not that the corner has no shape, the corner has a straight shape.

I put it as straight in the draft but we can resolve on this separately if we are ok with it, bring it back to none, or come up with something different.

This keyword is important for animating corner-shape.

@noamr noamr changed the title [css-shapes-2] naming of the "not curved" keyword for corner-shape [css-borders-4] naming of the "not curved" keyword for corner-shape Jan 30, 2025
@noamr noamr changed the title [css-borders-4] naming of the "not curved" keyword for corner-shape [css-borders-4] naming of the "not curved" (90deg convex) keyword for corner-shape Jan 30, 2025
@tabatkins
Copy link
Member

I agree that using a different keyword than none is better here, now that values are animatable. I think straight is reasonable.

@jsnkuhn
Copy link

jsnkuhn commented Jan 31, 2025

Definitely agreed a none shape option doesn't really make sense. There is definitely a shape just a common one.

Going to throw square on the pile as I think it better represents the actual shape of the default corner. I guess technically rectangle might be more correct if the size of the defined corner has a different width than height but square is close enough and it's shorter.

straight makes me think of a straight line which this isn't. It's a 90deg angle.

Wouldn't this shape also be the initial value: #11623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants