change: Update 'relative high resolution time' to use the principal realm. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
The change LGTM, but I see that the "principal realm" definition is not found? Does it need to be exported from somewhere, or explicitly imported? |
annevk
reviewed
Nov 27, 2024
index.html
Outdated
| <ol> | ||
| <li>Let |settings:environment settings object| be the |global|'s | ||
| [=global object/realm=]'s [=realm/principal realm=]'s | ||
| [=relevant settings object=]. |
There was a problem hiding this comment.
Why is there no relevant principal settings object? Wouldn't this require a lot of indirection everywhere?
|
(You can't merge this until the HTML ShadowRealm PR is considered done.) |
noamr
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/html#9893.
Closes #???
Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:
If this is a "change", please explain what's significantly changing.
In particular, if the change results in potential backwards compatibility issues and content breakage, it needs to be justified.
For normative spec changes, please get implementation commitments anf file issues on the various engines during the review process. All tasks should be complete before merging.
Implementation commitment - primarily for "change" and other normative changes:
Tasks:
Preview | Diff