From 5664b384ec31c2105f237b5b63f1d860ebef349c Mon Sep 17 00:00:00 2001 From: Noam Rosenthal Date: Thu, 1 Feb 2024 10:31:53 +0000 Subject: [PATCH] Fix type of sourceCharPosition attribute, and amend explainer --- index.bs | 2 +- loaf-explainer.md | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/index.bs b/index.bs index 23e7ce1..4e3b1ee 100644 --- a/index.bs +++ b/index.bs @@ -424,7 +424,7 @@ The {{PerformanceLongAnimationFrameTiming/scripts}} attribute's getter steps are readonly attribute DOMHighResTimeStamp executionStart; readonly attribute DOMString sourceURL; readonly attribute DOMString sourceFunctionName; - readonly attribute DOMString sourceCharPosition; + readonly attribute long long sourceCharPosition; readonly attribute DOMHighResTimeStamp pauseDuration; readonly attribute DOMHighResTimeStamp forcedStyleAndLayoutDuration; readonly attribute Window? window; diff --git a/loaf-explainer.md b/loaf-explainer.md index e1db991..9f0a743 100644 --- a/loaf-explainer.md +++ b/loaf-explainer.md @@ -304,7 +304,9 @@ const someLongAnimationFrameEntry = { // In the case of promise resolver this would be the invoker's source location // Note that we expose character position rather than line/column to avoid overhead of line splitting. - sourceLocation: "functionName@URL:characterPosition", + sourceURL: "https://example.com/big.js", + sourceFunctionName: "do_something_long", + sourceCharPosition: 10, // Relationship between the (same-origin) window where this script was executed and // this window.