Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Application/cbor-diagnostic #328

Open
mkhraisha opened this issue Feb 5, 2025 · 2 comments · May be fixed by w3c/respec-vc#54
Open

Remove Application/cbor-diagnostic #328

mkhraisha opened this issue Feb 5, 2025 · 2 comments · May be fixed by w3c/respec-vc#54
Assignees
Labels
CR1 editorial Editorial changes only

Comments

@mkhraisha
Copy link

https://w3c.github.io/vc-jose-cose/#example-a-simple-example-of-a-verifiable-credential-secured-with-cose

Remove the application/cbor-diagnostic header from the spec as it appears to be incorrect.

Image

@mkhraisha
Copy link
Author

@msporny lmk what I can do to help out with this, I don't believe I have access to any respec config/build , it seems the most I can do is modify things in this repo.

@msporny
Copy link
Member

msporny commented Feb 5, 2025

The issue is with this code block

https://github.com/w3c/respec-vc/blob/main/src/cose.js#L87-L125

Once that is commented out or removed we would need to make a new release of respec-vc and then use that new version in the vc-jose-cose spec.

@mkhraisha mkhraisha linked a pull request Feb 5, 2025 that will close this issue
@msporny msporny added editorial Editorial changes only CR1 labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 editorial Editorial changes only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants