Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should steps 28 and 29 occur before Step 27 in the registration ceremony #2204

Open
zacknewman opened this issue Nov 14, 2024 · 1 comment · May be fixed by #2215
Open

Should steps 28 and 29 occur before Step 27 in the registration ceremony #2204

zacknewman opened this issue Nov 14, 2024 · 1 comment · May be fixed by #2215

Comments

@zacknewman
Copy link
Contributor

zacknewman commented Nov 14, 2024

Currently step 27 occurs before steps 28 and 29; however it seems weird to "create and store a new credential record in the user account" before successfully completing steps 28 and 29, right? This means one could save a credential even though the ceremony fails later.

A similar issue exists for the authentication ceremony where step 23 occurs before steps 24 and 25.

I think moving those steps last makes the most sense since this way any credential creation or update occurs iff the ceremony succeeds.

@sbweeden
Copy link
Contributor

sbweeden commented Nov 20, 2024

agree this should be switched. @emlun to create PR per WG call on 20 Nov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants