-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Credential Record to suggest storing RP ID as well for better Related Origins support #2257
Comments
I think I get the idea, but on further thought this might be a bit of a trap. The idea is that an RP might use two (or more) different RP IDs, but wants to merge them into one logical application? Say that But this might still become a problem when it's time for a user to log in to the merged site, because in that call you can only specify one RP ID at a time. Let's consider only discoverable credentials (empty Non-discoverable credentials (non-empty So while I like the proposal on one level, I'm not sure this is the right way. This would imply that storing the RP ID tags is enough to solve any issues that come up with related origins, but it isn't. It wouldn't hurt, but it's not enough. So I rather feel like this use case would need much deeper consideration than this simple recommendation. |
Thanks for the thorough analysis @emlun. Looking at the current definition of Related Origins in L3, and comparing it to the Explainer, I'm not certain how Related Origins supports websites that have users with passkeys spread across those multiple RP IDs. I've had it in my head that Related Origins requires use of a single static RP ID across multiple domains, since the processing rules reference "
...I can't see how Related Origins, as it currently exists in L3, can handle this use case. Assuming an empty I suppose this biggest question on my mind at this point is, is Related Origins trying to solve for A) RP |
Storing the RP ID is valuable for identifier-first flows in brownfield/existing deployments as covered here: https://passkeys.dev/docs/advanced/related-origins/#existing-deployments It is not needed for greenfield deployments where a common RP ID is used across all origins (but still may be a good practice to store in case of future changes). |
Proposed Change
An RP that wants to use Related Origins during authentication would benefit greatly from storing with a credential the RP ID that was specified during its registration. We should update Credential Record to add a new value accordingly.
We'd want to update Step 27 under 7.1. Registering a New Credential to then populate this value accordingly.
The text was updated successfully, but these errors were encountered: