-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NOTEs non-normative #2196
Open
emlun
wants to merge
32
commits into
main
Choose a base branch
from
issue-1979-notes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Make NOTEs non-normative #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
requested review from
MasterKale,
timcappalli,
selfissued,
nadalin and
akshayku
November 13, 2024 17:18
…icator extensions
emlun
force-pushed
the
issue-1979-notes
branch
from
November 13, 2024 17:23
6c5c575
to
72d47d0
Compare
timcappalli
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
akshayku
approved these changes
Nov 13, 2024
selfissued
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1979.
This changes some NOTEs into normative text, and "promotes" some occurrences of "must" and "should" to their RFC 8174-enforced uppercase forms; thus formally speaking this introduces new normative language to the spec. But I have done my best to preserve what I interpret as the spirit of the existing language, so I think one can argue that these still count as "just" editorial changes.
Preview | Diff