Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for a navigationCommited event to inform immediately about the navigation status #788

Open
whimboo opened this issue Sep 24, 2024 · 2 comments
Labels
enhancement New feature or request module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group

Comments

@whimboo
Copy link
Contributor

whimboo commented Sep 24, 2024

This is a request from the Playwright folks:

Introduce an event or method to track when a navigation is committed, beyond the current DOMContentLoaded and load events, which would be useful for some client requirements (e.g., 'should return when navigation is committed if commit is specified'). We need to know immediately if the navigation has failed or succeeded.

In Puppeteer this event is named page.frameNavigated.

It's not clear right now where in the HTML spec it could hook into to accurately inform about the status of the current navigation.

@whimboo whimboo added enhancement New feature or request module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group labels Sep 24, 2024
@css-meeting-bot
Copy link
Member

The Browser Testing and Tools Working Group just discussed Request for a navigationCommited event to inform immediately about the navigation status.

The full IRC log of that discussion <simonstewart> Topic: Request for a navigationCommited event to inform immediately about the navigation status
<simonstewart> github: https://github.com//issues/788
<simonstewart> Action: someone in chrome to find out what a `navigationCommited` actually is, and what it corresponds to in a spec

@OrKoN
Copy link
Contributor

OrKoN commented Oct 25, 2024

Action: someone in chrome to find out what a navigationCommited actually is, and what it corresponds to in a spec

It happens here https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/loader/document_loader.cc;l=2152;drc=c5f3a25855b895bb587af5dbd8ff3ebfb7be76e1 and I believe it roughly corresponds to this step in the HTML spec https://html.spec.whatwg.org/multipage/browsing-the-web.html#populating-a-session-history-entry:loading-a-document

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group
Projects
None yet
Development

No branches or pull requests

3 participants