-
Notifications
You must be signed in to change notification settings - Fork 32
Merging @foxglove/avl upstream? #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi John!
Yes, I would be happy to merge! Thank you so much
Kind regards,
Alexander Milevski
… On 14 Sep 2021, at 05:57, John Hurliman ***@***.***> wrote:
I just released the @foxglove/avl package to unblock waiting on some of the open PRs to this repo to merge, implementations of new functions such as findLessThan[OrEqual], findGreaterThan[OrEqual], cleaning up the naming convention to look more like ES6 containers such as Map<K, V> and Set<K>, and porting to TypeScript. Is there interest in merging this code into this repo and the avl package? If so, I can deprecate the @foxglove/avl package and direct users here. I'm also happy to continue maintaining @foxglove/avl if you'd prefer to keep the existing codebase.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
I'll be waiting for a PR, appreciate your contribution |
@jhurliman do you still want to do it? |
@w8r yes apologies, I'm just now returning from holiday. I will start preparing a PR this week. |
great! Let me know if you need help |
Apologies for the delay, see #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just released the @foxglove/avl package to unblock waiting on some of the open PRs to this repo to merge, implementations of new functions such as findLessThan[OrEqual], findGreaterThan[OrEqual], cleaning up the naming convention to look more like ES6 containers such as
Map<K, V>
andSet<K>
, and porting to TypeScript. Is there interest in merging this code into this repo and theavl
package? If so, I can deprecate the@foxglove/avl
package and direct users here. I'm also happy to continue maintaining@foxglove/avl
if you'd prefer to keep the existing codebase.The text was updated successfully, but these errors were encountered: