Merge pull request #50 from patrislav1/fix-viewbox

fix: viewBox attr when using pixel units

README.md

@@ -74,7 +74,9 @@ go build -o ansisvg .
 
 By default, `ansisvg` uses font-relative `ch`/`em` coordinates. This should make SVG dimensions and line/character spacing consistent with font family/size. When SVG dimensions and/or text coordinates are off, it is possible to force explicit pixel units for coordinates by specifying `-charboxsize` in X/Y pixel units, e.g. `8x16`.
 
-Inkscape currently [cannot deal with SVG size expressed in font-relative units](https://gitlab.com/inkscape/inkscape/-/issues/4737), a quick workaround is Ctrl-Shift-R (resize page to content).
+* Inkscape currently [cannot deal with SVG size expressed in font-relative units](https://gitlab.com/inkscape/inkscape/-/issues/4737), a quick workaround is Ctrl-Shift-R (resize page to content).
+
+* Some SVG processing tools like [asciidoctor](https://docs.asciidoctor.org/pdf-converter/latest/image-paths-and-formats/#image-formats) require the presence of the `viewBox` attribute. Use `-charboxsize` option to enable this attribute (it only works with pixel dimensions).
 
 ## Margin size
 

svgscreen/svgscreen.go

@@ -55,6 +55,7 @@ type bgRect struct {
 type SvgDom struct {
 	Width          string
 	Height         string
+	ViewBox        string
 	FontName       string
 	FontEmbedded   []byte
 	FontRef        string
@@ -308,10 +309,14 @@ func (s *Screen) Render(w io.Writer) error {
 		// Font-relative coordinates
 		s.Dom.Width = s.columnCoordinate(float32(s.TerminalWidth)+2*s.MarginSize.X, false)
 		s.Dom.Height = s.rowCoordinate(float32(s.NrLines)+2*s.MarginSize.Y, false)
+		s.Dom.ViewBox = ""
 	} else {
 		// Pixel coordinates
-		s.Dom.Width = fmt.Sprintf("%gpx", float32(s.CharacterBoxSize.X*s.TerminalWidth)+2*s.MarginSize.X)
-		s.Dom.Height = fmt.Sprintf("%gpx", float32(s.CharacterBoxSize.Y*s.NrLines)+2*s.MarginSize.Y)
+		w := float32(s.CharacterBoxSize.X*s.TerminalWidth) + 2*s.MarginSize.X
+		h := float32(s.CharacterBoxSize.Y*s.NrLines) + 2*s.MarginSize.Y
+		s.Dom.Width = fmt.Sprintf("%gpx", w)
+		s.Dom.Height = fmt.Sprintf("%gpx", h)
+		s.Dom.ViewBox = fmt.Sprintf("0 0 %g %g", w, h)
 	}
 
 	s.handleColorInversion()