Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure recognising numeric participant ID numbers that are accidentally stored with decimal places #1256

Open
vincentvanhees opened this issue Jan 24, 2025 · 0 comments

Comments

@vincentvanhees
Copy link
Member

vincentvanhees commented Jan 24, 2025

Problem

A user accidentally stored the participant ID number in the sleeplog with decimal places (144.00 in the example below)

Image

which are not shown by Excel

Image

causing that the sleep diary for this person could not be matched with the accelerometer file ID (144).

When I open the csv file in Excel and save it without making edits, the decimal places disappear:
Image

and the sleep diary is successfully linked to the accelerometer data.

Proposed solution

I would hope that most GGIR users notice this and resolve it themself, but it is concerning that this can happen.

My first idea for a solution was to let GGIR code attempt to interpret ID as number and if it is possible check that there are no decimal places. This would come with the disadvantage that IDs with intentional decimal places are no longer permitted.

Instead, I propose:
At the end of processing the sleeplog let GGIR store the full list of IDs that could not be matched in a text file and display a warning message in the console with a reference to the text file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant