Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge ProtocolUseOptions and ProtocolCreateOptions #2048

Closed
danisharora099 opened this issue Jun 27, 2024 · 1 comment
Closed

chore: merge ProtocolUseOptions and ProtocolCreateOptions #2048

danisharora099 opened this issue Jun 27, 2024 · 1 comment
Labels
debt Technical debt marker enhancement New feature or request

Comments

@danisharora099
Copy link
Collaborator

This is a change request

Problem

Based on the introduction of ProtocolUseOptions in #2047, there is some merit in keeping one type with ProtocolCreateOptions.

They have keys which might have better correlation with keys from the other type.

Proposed Solutions

Either form a clear distinction, or merge, the type ProtocolUseOptions with ProtocolCreateOptions
@danisharora099 danisharora099 added the enhancement New feature or request label Jun 27, 2024
@danisharora099 danisharora099 mentioned this issue Jun 27, 2024
Merged
3 tasks
@fryorcraken fryorcraken added this to Waku Jun 27, 2024
@weboko weboko moved this to Triage in Waku Jun 27, 2024
@weboko weboko moved this from Triage to To Do in Waku Jun 27, 2024
@weboko weboko added the debt Technical debt marker label Jun 27, 2024
@danisharora099 danisharora099 mentioned this issue Jul 18, 2024
Open
@weboko
Copy link
Collaborator

weboko commented Mar 24, 2025

Done in #2191

@weboko weboko closed this as completed Mar 24, 2025
@github-project-automation github-project-automation bot moved this from To Do to Done in Waku Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt Technical debt marker enhancement New feature or request
Projects
Waku
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danisharora099 @weboko