From 1730ecedd72c0ced10df20226f0efd8024bf2043 Mon Sep 17 00:00:00 2001 From: Flamarion Jorge Date: Fri, 1 Dec 2023 09:56:46 +0100 Subject: [PATCH 1/2] fix: Fix private access example --- examples/private-access-only/main.tf | 18 ++++++++++-------- examples/private-access-only/variables.tf | 19 +++++++++++++++++-- examples/private-access-only/versions.tf | 4 ++-- 3 files changed, 29 insertions(+), 12 deletions(-) diff --git a/examples/private-access-only/main.tf b/examples/private-access-only/main.tf index 6c56c856..eb71fcf0 100644 --- a/examples/private-access-only/main.tf +++ b/examples/private-access-only/main.tf @@ -1,5 +1,6 @@ provider "aws" { - region = "us-east-2" + region = "eu-central-1" + profile = "sandbox-admin" default_tags { tags = { @@ -61,18 +62,19 @@ module "standard" { namespace = var.namespace public_access = false - wandb_license = var.wandb_license - domain_name = aws_route53_zone.private.name zone_id = aws_route53_zone.private.zone_id # Creating a custom VPC so that we can initalize a route53 zone first and configure a vpn - create_vpc = false - network_id = module.networking.vpc_id - network_private_subnets = module.networking.private_subnets - network_public_subnets = module.networking.public_subnets + create_vpc = false + network_id = module.networking.vpc_id + network_private_subnets = module.networking.private_subnets + network_public_subnets = module.networking.public_subnets + allowed_inbound_cidr = var.allowed_inbound_cidr + allowed_inbound_ipv6_cidr = var.allowed_inbound_ipv6_cidr + eks_cluster_version = var.eks_cluster_version } output "url" { value = module.standard.url -} \ No newline at end of file +} diff --git a/examples/private-access-only/variables.tf b/examples/private-access-only/variables.tf index e829a2ee..d66f3807 100644 --- a/examples/private-access-only/variables.tf +++ b/examples/private-access-only/variables.tf @@ -3,7 +3,22 @@ variable "namespace" { description = "Name prefix used for resources" } -variable "wandb_license" { - type = string +variable "allowed_inbound_cidr" { + default = ["0.0.0.0/0"] + nullable = false + type = list(string) } + +variable "allowed_inbound_ipv6_cidr" { + default = ["::/0"] + nullable = false + type = list(string) +} + +variable "eks_cluster_version" { + description = "EKS cluster kubernetes version" + default = "1.26" + nullable = false + type = string +} diff --git a/examples/private-access-only/versions.tf b/examples/private-access-only/versions.tf index ee9da534..6276e085 100644 --- a/examples/private-access-only/versions.tf +++ b/examples/private-access-only/versions.tf @@ -2,7 +2,7 @@ terraform { required_providers { aws = { source = "hashicorp/aws" - version = "~> 3.60" + version = "~> 4.0" } } -} \ No newline at end of file +} From 568d169b60c170035bd2e48fd34b4e0acf29cd33 Mon Sep 17 00:00:00 2001 From: Flamarion Jorge Date: Fri, 1 Dec 2023 09:57:40 +0100 Subject: [PATCH 2/2] Remove test configuration --- examples/private-access-only/main.tf | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/private-access-only/main.tf b/examples/private-access-only/main.tf index eb71fcf0..de412ae5 100644 --- a/examples/private-access-only/main.tf +++ b/examples/private-access-only/main.tf @@ -1,6 +1,5 @@ provider "aws" { - region = "eu-central-1" - profile = "sandbox-admin" + region = "us-east-2" default_tags { tags = {