Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write proper tests for daemon.rs and server.rs #40

Open
Shinyzenith opened this issue Feb 9, 2022 · 5 comments
Open

Write proper tests for daemon.rs and server.rs #40

Shinyzenith opened this issue Feb 9, 2022 · 5 comments
Assignees
Labels
Documentation Improvements or additions to documentation Enhancement New feature or request Help wanted Extra attention is needed

Comments

@Shinyzenith
Copy link
Member

No description provided.

@Shinyzenith Shinyzenith added Documentation Improvements or additions to documentation Enhancement New feature or request Help wanted Extra attention is needed labels Feb 9, 2022
@Shinyzenith
Copy link
Member Author

Shinyzenith commented Mar 26, 2022

This really needs some attention as soon as we are done with the CVE's, keychord, and modal feature.

@waycrate waycrate deleted a comment from angelofallars Mar 26, 2022
@waycrate waycrate deleted a comment from angelofallars Mar 26, 2022
@ajanon
Copy link
Collaborator

ajanon commented Dec 18, 2022

I think we need integration tests for the daemon. Given how much we interact with the system, I don't think unit tests would be really helpful.

Ideally, we would run our integration tests in a VM/container to ensure swhkd behaves as expected (e.g., grabs devices properly, does not miss events...). This might be tricky to implement, though.

@Shinyzenith
Copy link
Member Author

Yep it seems tricky indeed, do you have any possible solutions in mind?

@ajanon
Copy link
Collaborator

ajanon commented Dec 18, 2022

I have been using spread in another project. It does not seem easy to set up, but it is easy to use after the initial setup. I am not sure how compatible this would be with GitHub actions, though.

We could also very well develop our own ad-hoc scripts to set up VMs/containers and test from there. This may be rather costly to implement.

@Shinyzenith
Copy link
Member Author

Cool! I'll take a look at spread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Enhancement New feature or request Help wanted Extra attention is needed
Development

No branches or pull requests

3 participants