Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support responsiveArray #124

Closed
sebtoombs opened this issue Mar 7, 2023 · 1 comment
Closed

Support responsiveArray #124

sebtoombs opened this issue Mar 7, 2023 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@sebtoombs
Copy link
Contributor

Hey @roginfarrer would you be interested in a PR to add support for responsiveArray?

Problem Statement

Currently, rainbow-sprinkles does not support the responsiveArray property when using defineProperties. See Vanilla-Extract/sprinkles: https://vanilla-extract.style/documentation/packages/sprinkles/#responsivearray

Proposed Solution

See draft PR: #123
@roginfarrer
Copy link
Collaborator

I'm not a fan of the responsiveArray syntax. I think it's illegible to those unfamiliar with the syntax, and it's very difficult to change or introduce new breakpoints without breaking existing implementations. I'm also concerned about introducing an additional level of complexity to the types, which are already very complicated due to merging static and dynamic properties. So I'd be worried about maintaining this in the future.

Thanks for the issue and PR, but I'm going to say no for now.

@roginfarrer roginfarrer added enhancement New feature or request wontfix This will not be worked on labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roginfarrer @sebtoombs