-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the workers path calculations #161
base: main
Are you sure you want to change the base?
Conversation
Thank you for the PR. |
They are failing due to having a test that checks such a scenario as I wrote in the PR description, and I can't figure out a way to handle it. Essentially we are pushing our patch into the The problem is that using I guess one workaround is to make Unless |
aa96d3d
to
7ca61b3
Compare
7ca61b3
to
3e20d57
Compare
Offf is there really no way to Why oh why is everything so goddamn difficult in JS... |
pinoBundlerRan
check in case there are multiple pino.js modules around, might fix some cases of the__bundlerPathsOverrides
being missing leading to it looking forlib/worker.js
and failing__dirname
based strategy forpinoBundlerAbsolutePath
, more complex outputs layout might require some more thought on how to figure out the relative path from the current file to the workers if they are not together - fixes Usingprocess.cwd
is problematic #159pinoBundlerAbsolutePath
into a virtual module so it can safely useimport.meta.url
or__dirname
depending on the format. This makes it work in ESM mode, minus the "Dynamic require is not supported" issue of esbuild, which needs a workaround in your esbuild config - How to fix "Dynamic require of "os" is not supported" evanw/esbuild#1921