Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape css ident #7743

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: escape css ident #7743

merged 1 commit into from
Sep 3, 2024

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Aug 30, 2024

Summary

#7719

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Aug 30, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 30, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit c164c12
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66d5df07e4b8580008ff4f3c

@inottn inottn force-pushed the fix/7719 branch 3 times, most recently from 98e009c to e3b52de Compare September 1, 2024 17:02
@ahabhgk
Copy link
Contributor

ahabhgk commented Sep 2, 2024

Looks good to me, could you add a test case, just for avoiding regression

@JSerFeng JSerFeng merged commit e903266 into web-infra-dev:main Sep 3, 2024
28 checks passed
@JSerFeng
Copy link
Contributor

JSerFeng commented Sep 3, 2024

Thanks !

@chenjiahan chenjiahan mentioned this pull request Sep 4, 2024
Merged
@renovate renovate bot mentioned this pull request Sep 27, 2024
Merged
1 task
@inottn inottn deleted the fix/7719 branch October 1, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSerFeng JSerFeng JSerFeng approved these changes

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inottn @ahabhgk @JSerFeng