Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support module.generator.outputPath #8554

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support module.generator.outputPath #8554

wants to merge 1 commit into from
+94 −15

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Nov 28, 2024

Summary

close #8539

module.generator.outputPath is used to specify the output folder for generated assets. While filename can achieve a similar result, it also modifies the associated URL. For example:

generator: {
  // put emitted files under `assets/*.png`
  // runtime request from `https://xxx/cdn/assets/*.png`
  filename: 'assets/[hash][ext][query]',
  publicPath: 'https://xxx/cdn/'
}

generator: {
  // put emitted files under `assets/*.png`
  // runtime request from `https://xxx/cdn/*.png`
  filename: '[hash][ext][query]',
  outputPath: 'assets'
  publicPath: 'https://xxx/cdn/'
}

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Nov 28, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4a0942a
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6747e218965100000870fa25
😎 Deploy Preview https://deploy-preview-8554--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #8554 will not alter performance

Comparing inottn:feat/generator-outputPath (4a0942a) with main (a8fc586)

Summary

✅ 1 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Should apply module.generator.outputPath
1 participant
@inottn