Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reuse swc ast struct #8563

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf: reuse swc ast struct #8563

wants to merge 1 commit into from
+537 −189

Conversation

GiveMe-A-Name
Copy link
Member

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Nov 28, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit f8f7ec3
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67484623e6f2210008323cb1

@GiveMe-A-Name
Copy link
Member Author

!bench

@rspack-bot
Copy link

⏳ Triggered benchmark: Open

@GiveMe-A-Name GiveMe-A-Name marked this pull request as draft November 28, 2024 10:58
@GiveMe-A-Name GiveMe-A-Name changed the title perf: reuse swc ast struct(benchmark) perf: reuse swc ast struct Nov 28, 2024
@GiveMe-A-Name
Copy link
Member Author

TODO: swc-loader -> xx-loader -> jsParser
Maybe It have other loader to transform js. So in this situations, we also parse twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GiveMe-A-Name GiveMe-A-Name

Labels
release: performance release: performance related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiveMe-A-Name @rspack-bot