Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

4.0 support? #156

Closed
azaslavsky opened this issue Jun 8, 2016 · 6 comments
Closed

4.0 support? #156

azaslavsky opened this issue Jun 8, 2016 · 6 comments

Comments

@azaslavsky
Copy link

azaslavsky commented Jun 8, 2016

Hi,
I noticed that there is a large disclaimer that 3.0 is not yet supported, but that the dependency in the package.json file is ^4.0.9? Does this mean that 4.x+ is supported, but that this library is not yet backwards compatible with 3.x? Or are neither 3.x nor 4.x supported?

@meleyal
Copy link

meleyal commented Jun 15, 2016

@azaslavsky I think 4.x support is happening in beta-rc1.

PR #146 works with 4.x, but not sure how stable that is.

@meleyal
Copy link

meleyal commented Jun 15, 2016

Provisional Todo list:

@christian-bromann anything missing?

Sorry, something went wrong.

@azaslavsky
Copy link
Author

Thanks for the response, @meleyal!

I ended up using wdio-screenshot and wdio-visual-regression-service instead, which, as far as I have been able to tell, work great with 4.x. The only downside is that their APIs are a little less robust than this one (no exclusions, for example), but I'm sure that will be fixed with time.

It's worth mentioning that they are both already written with async/await, so perhaps they could be used as dependencies for this library under the hood?

@meleyal
Copy link

meleyal commented Jun 16, 2016

@azaslavsky I also switched for now. There's an issue here about possibly merging the two projects: zinserjan/wdio-screenshot#5

@mCzolko
Copy link

mCzolko commented Jul 25, 2016

Hi,
what is the ETA on this?

@christian-bromann
Copy link
Contributor

please see #156 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants