You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On some occasions, in order to provide a helpful error message, more processing is required to provide a helpful message:
$message = $createMessage(...); // heavy stuff happening there
Assert::smth(..., $message);
Maybe it would be cool to have support for $message being string|():string instead of just string:
Assert::smth(..., $createMessage);
In some cases this may end up more verbose, but on the other hand it prevents the assertion from being expensive in case of non-failure (the happy path).
WDYT?
The text was updated successfully, but these errors were encountered:
Doing some profiling on our app, it often happens that sprintf() calls with complex processing (implode and such) are the culprit of bad performance. Worst than that, 99% of the time they are executed without any need to.
It's sad to have to use if (...) { throw new InvalidArgumentException(...); } instead of Assert just for that reason... @BackEndTea What would be needed to make this issue fixed? Is there a particular blocker?
On some occasions, in order to provide a helpful error message, more processing is required to provide a helpful message:
Maybe it would be cool to have support for
$message
beingstring|():string
instead of juststring
:In some cases this may end up more verbose, but on the other hand it prevents the assertion from being expensive in case of non-failure (the happy path).
WDYT?
The text was updated successfully, but these errors were encountered: