Optimize isList #285
Merged
Optimize isList #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowhand
approved these changes
Oct 16, 2024
kamil-tekiela
force-pushed
the
Improve-isList
branch
from
d550750 to
6fff132
Compare
shadowhand
reviewed
Oct 16, 2024
Comment on lines
+1891
to
+1892
| $keys = array_keys($array); | ||
| if (array_keys($keys) !== $keys) { |
There was a problem hiding this comment.
Try running composer run cs-fix
There was a problem hiding this comment.
I get "The system cannot find the path specified."
There was a problem hiding this comment.
I've downloaded it and run it manually. Is this what you meant? It changed the array style to the old style.
There was a problem hiding this comment.
composer run install-tools first.
There was a problem hiding this comment.
Thanks, same outcome though. It still uses the old array syntax.
There was a problem hiding this comment.
You need to add \ before array_keys, I think? But cs says it passes, so maybe not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to the discussion from #247.
During normal usage, I noticed this function is very inefficient. It doesn't use the built-in function
array_is_listand the polyfil is very inefficient for most cases. Yes, the current implementation is very efficient for true lists, but has very bad performance with any other list, e.g. the one from the previous PR.The current implementation would benefit from a very simple optimization:
foreach (array_keys($array) as $k) {but no sense in doing this if we can achieve an overall better performance with justarray_keys.The current implementation builds a new array in memory. This is super efficient if the array was built like this
range(1, 1000). But if the array is large and contains other arrays or objects then building a copy of it is very bad. So we need to get rid ofarray_values(). This also solves the issue from previous PR because we are no longer comparing the values.This is the most efficient and the most correct implementation I could find.