Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validRegexPattern assertions #305

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zlodes
Copy link

@zlodes zlodes commented Oct 20, 2024

Why?

  1. PHP functions working with regex (preg_match, preg_replace, etc.) work in legacy way — they just return false instead of throwing exception.
  2. The way to check if the string is regex is quite hacky, so, would be great to hide the check implementation somewhere.

References

  1. https://stackoverflow.com/a/8825096/3578207

@zlodes
Copy link
Author

zlodes commented Oct 20, 2024

I see that some tests failed. Fixing. 🤔

@zlodes
Copy link
Author

zlodes commented Nov 23, 2024

@shadowhand Hello mate!

As I can see, the latest release of the package was in 2022. Is there any plans for the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants