Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Syntax error on webOS 3.0 #151

Closed
throwaway96 opened this issue Apr 2, 2024 · 14 comments
Closed

Bug: Syntax error on webOS 3.0 #151

throwaway96 opened this issue Apr 2, 2024 · 14 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@throwaway96
Copy link
Member

See webosbrew/webos-homebrew-channel#179 (here).

@jospezial
Copy link

The non working green button and no adblock in videos is since https://github.com/webosbrew/youtube-webos/releases/tag/v0.3.3-rc1
That works in https://github.com/webosbrew/youtube-webos/releases/tag/v0.3.2

@throwaway96
Copy link
Member Author

@fire332
Copy link

fire332 commented Apr 4, 2024

@throwaway96 To reply to your comment here, the updates to some babel dependencies could be related but that's all I got. Have you looked at the diff to see where it's erroring?

@jospezial
Copy link

Please try this build: https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.4-dev1

adblock works again when playing videos.
Can navigate in adblock menu but checkboxes don't change with "OK" -key.

When I was on first ad tile in "recommended" and pressed green key, the adblock menu window did not have the focus?
Up/down moved through video tiles behind the adblock menu.

@fire332
Copy link

fire332 commented Apr 4, 2024

When I was on first ad tile in "recommended" and pressed green key, the adblock menu window did not have the focus?
Up/down moved through video tiles behind the adblock menu.

I've noticed this too on my C1 on my branch. I have to wait a little bit after opening the config menu before pressing up/down to navigate through the config menu or the focus will still be in youtube for some reason.

@cremor
Copy link

cremor commented Apr 4, 2024

Can navigate in adblock menu but checkboxes don't change with "OK" -key.

Maybe related to #143?

When I was on first ad tile in "recommended" and pressed green key, the adblock menu window did not have the focus?
Up/down moved through video tiles behind the adblock menu.

This is not a new problem, I've already seen this in older verisons. Just close and open the settings again and it should work.

@igorkulman
Copy link

Please try this build: https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.4-dev1

I can confirm this also works for me.

@throwaway96
Copy link
Member Author

throwaway96 commented Apr 6, 2024

@cremor

This is not a new problem, I've already seen this in older verisons. Just close and open the settings again and it should work.

Did you have this problem in 0.3.1 or older?

(I just got it to happen on 0.3.1. So... not my fault! Opened issue #157 to track.)

@cremor
Copy link

cremor commented Apr 7, 2024

Did you have this problem in 0.3.1 or older?

0.3.1 was the current version when I started to use the app, and it was the version where I noticed it first.

@Meth69
Copy link

Meth69 commented Apr 7, 2024

Please try this build: https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.4-dev1

I'm on webOS 3.9.0 and can confirm the 0.3.4-dev1 works, whereas 0.3.3 didn't open the settings menu and didn't block ads.

@throwaway96
Copy link
Member Author

Should be fixed as a side effect of #146.

Please try 0.3.4-rc1.

@jospezial
Copy link

0.3.4-rc1

Can navigate in adblock menu but checkboxes don't change with "OK" -key.
The adblock menu window still looses focus and then remote control controls youtube in background.

@throwaway96
Copy link
Member Author

@jospezial

See #157.

@throwaway96
Copy link
Member Author

Well, this has been fixed at least. Ugh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants