fix: save point before making frame in case it moves. #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org-noter
stopped working for me recently and I traced it tocreate-frame
modifyingpoint
(specifically, moving it to the end of the buffer). This causes a subsequent call toorg-noter--parse-root
to fail since it's on the the wrong part of the buffer.I don't see anything in the release notes about
make-frame
no longer being idempotent. It could be something happening in a hook this end, but I've not got the time to look into it at the moment. But in any case I can't see any harm in settingcurrent-pos
before callingmake-frame
, which ensures this works even on potentially broken systems.NB I realise this repository is basically abandoned, but there doesn't seem to be a definitive fork so I'm dropping it here in case anyone else has this problem.