Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save point before making frame in case it moves. #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

2e0byo
Copy link

@2e0byo 2e0byo commented Apr 13, 2022

org-noter stopped working for me recently and I traced it to create-frame modifying point (specifically, moving it to the end of the buffer). This causes a subsequent call to org-noter--parse-root to fail since it's on the the wrong part of the buffer.

I don't see anything in the release notes about make-frame no longer being idempotent. It could be something happening in a hook this end, but I've not got the time to look into it at the moment. But in any case I can't see any harm in setting current-pos before calling make-frame, which ensures this works even on potentially broken systems.

NB I realise this repository is basically abandoned, but there doesn't seem to be a definitive fork so I'm dropping it here in case anyone else has this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant