Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ghc 9.6 #151

Closed
wants to merge 1 commit into from
Closed

Conversation

TristanCacqueray
Copy link
Contributor

No description provided.

@TristanCacqueray
Copy link
Contributor Author

Well, I haven't tried the change, this simply fix the compilation errors. This depends on: ndmitchell/record-dot-preprocessor#59

gbrsales added a commit to gbrsales/large-records that referenced this pull request May 20, 2024
gbrsales added a commit to gbrsales/large-records that referenced this pull request May 24, 2024
gbrsales added a commit to gbrsales/large-records that referenced this pull request May 25, 2024
gbrsales added a commit to gbrsales/large-records that referenced this pull request May 25, 2024
gbrsales added a commit to gbrsales/large-records that referenced this pull request May 25, 2024
@alexfmpe
Copy link

@edsko would it be possible to get this merged?
large-generics (and dependants) is broken for 9.6+ on nixpkgs and applying this PR over there doesn't work because the merge of #152 gave it conflicts

@edsko
Copy link
Collaborator

edsko commented May 29, 2024

I appreciate the work that @TristanCacqueray did, but it only got us part of the way there. But hopefully I should have an updated PR soon, and then I will make Hackage releases.

@gbrsales gbrsales mentioned this pull request May 29, 2024
@TristanCacqueray
Copy link
Contributor Author

You are welcome. Well, after fixing this build, I realized large-records was added transitively by proto3-suite through an optional flags, and it didn't look like this PR was enough, so we disabled the flags.

@alexfmpe
Copy link

alexfmpe commented May 29, 2024

Well, after fixing this build, I realized large-records was added transitively by proto3-suite through an optional flags, and it didn't look like this PR was enough, so we disabled the flags.

Oooh hadn't realised that. proto3-suite is also how large-records ends up in my dependency tree, and my current workaround is pointing at this PR, might look into the flag instead.

Anedoctal, but I was using nixpkgs' 9.4 package set until a couple weeks ago and at least with my specific dependencies this PR allows building large-records (and thus proto3-suite) on 9.6.
I'm pointing directly to it, skipping #152, but that requires callCabal2nix, which can't be used in nixpkgs, so no upstreaming option there either.

@edsko edsko mentioned this pull request May 30, 2024
@edsko
Copy link
Collaborator

edsko commented May 30, 2024

Closed in favour of #156. See discussion and acknowledgements there :)

@edsko edsko closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants