Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BigQuerySinkConfig extend from SinkConnectorConfig #266

Open
whynick1 opened this issue Apr 21, 2020 · 0 comments
Open

Make BigQuerySinkConfig extend from SinkConnectorConfig #266

whynick1 opened this issue Apr 21, 2020 · 0 comments

Comments

@whynick1
Copy link
Contributor

Currently, BigQuerySinkConfig extends from AbstractConfig. And then we copied some "configuration" and "validate logic" from SinkConnectorConfig.
To avoiding duplicate implementation/code, we should try to have BigQuerySinkConfig directly extends from SinkConnectorConfig.
@whynick1 whynick1 changed the title Have BigQuerySinkConfig extends from SinkConnectorConfig than AbstractConfig Make BigQuerySinkConfig extend from SinkConnectorConfig Apr 21, 2020
@whynick1 whynick1 mentioned this issue Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whynick1