-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some calls https://html.spec.whatwg.org/#set-the-ongoing-navigation could need some clarification #10800
Comments
Why do you think this? If we reach step 2 of https://html.spec.whatwg.org/#navigate-to-a-javascript:-url, we are aborting the ongoing navigation, and so we should inform the navigation API about it. |
Need to take a step back, there might be a preceding bug in the spec: when step 19 of https://html.spec.whatwg.org/#navigate is invoked, "ongoing navigation" may be null. |
What is wrong with invoking step 2 if there's no ongoing navigation? It will do nothing in that case. |
From an abstract point of view it's surprising that "inform the navigation API about aborting navigation" doesn't inform in that case. It's also not obvious if it does nothing. It seems it might also queue a task (which might do nothing). |
Based on the premise that step 2 does nothing, there is no technical issue. |
It is additionally confusing that:
would set the It might be clearer to pass something like "javascript-url" in step 20 of https://html.spec.whatwg.org/#navigate to a new call of https://html.spec.whatwg.org/#set-the-ongoing-navigation before queuing the |
What is the issue with the HTML Standard?
https://html.spec.whatwg.org/#set-the-ongoing-navigation should "inform the navigation API about aborting navigation" only if "navigable's ongoing navigation" is not null.
It's set to null e.g. in step 2 of https://html.spec.whatwg.org/#navigate-to-a-javascript:-url.
Edit: see #10800 (comment) and #10800 (comment) for proposals.
The text was updated successfully, but these errors were encountered: