Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button activation behavior can call "show a modal dialog" with not-connected dialog #11043

Open
zcorpan opened this issue Feb 19, 2025 · 0 comments · May be fixed by #11049
Open

Button activation behavior can call "show a modal dialog" with not-connected dialog #11043

zcorpan opened this issue Feb 19, 2025 · 0 comments · May be fixed by #11049

Comments

@zcorpan
Copy link
Member

zcorpan commented Feb 19, 2025

What is the issue with the HTML Standard?

The introduction of command/commandfor in #9841 specifies new activation behavior steps for button which can call "show a modal dialog" without checking if that dialog is connected, in which case it will throw an exception. It's not immediately clear to me what should happen in that case (should the exception be propagated to click()?).

Demo: https://software.hixie.ch/utilities/js/live-dom-viewer/saved/13512

As far as I can tell the other exception-throwing cases in "show a modal dialog" are already accounted for.

cc @keithamus

@lukewarlow lukewarlow linked a pull request Feb 19, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant