Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"valid domain" does not match validation errors in the host parser #797

Open
annevk opened this issue Oct 4, 2023 · 1 comment
Open
Labels
topic: validation Pertaining to the rules for URL writing and validity (as opposed to parsing)

Comments

@annevk
Copy link
Member

annevk commented Oct 4, 2023

Percent-encoding is a mismatch and tracked by #796.

However, "valid domain" also has a bunch of rules that the host parser does not attempt to log validation errors for. We should either make it log those validation errors or remove this mismatch. (To be specific, "valid domain" uses a different value for "domain to ASCII"'s toStrict parameter and also invokes "domain to Unicode".)

(Then there's #245 about not defining this in an imperative manner, which would have made this harder to spot presumably. Hmm.)

@annevk annevk added the topic: validation Pertaining to the rules for URL writing and validity (as opposed to parsing) label Oct 4, 2023
@annevk
Copy link
Member Author

annevk commented Nov 29, 2024

(#704 is the more general problem here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: validation Pertaining to the rules for URL writing and validity (as opposed to parsing)
Development

No branches or pull requests

1 participant