Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing not existing handling for 'protocol' in "process a URLPatternInit" #257

Open
shannonbooth opened this issue Feb 18, 2025 · 1 comment

Comments

@shannonbooth
Copy link

shannonbooth commented Feb 18, 2025

What is the issue with the URL Pattern Standard?

process a URLPatternInit is missing null handling in some of the steps, which can result in null being passed through when a string is expected.

This occurs on step 16:

  1. If init["port"] exists, then set result["port"] to the result of process port for init given init["port"], result["protocol"], and type.

And step 17.3:

  1. Set result["pathname"] to the result of process pathname for init given result["pathname"], result["protocol"], and type.

In both cases, result["protocol"] may be missing. It appears the intent is to pass in an empty string if missing.

@annevk
Copy link
Member

annevk commented Feb 18, 2025

cc @youennf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants