Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State saving and recovery is not good when using a smart drive #156

Open
dungeonkim opened this issue Sep 1, 2022 · 4 comments
Open

State saving and recovery is not good when using a smart drive #156

dungeonkim opened this issue Sep 1, 2022 · 4 comments

Comments

@dungeonkim
Copy link

If I save the state while using the Smart drive, it cannot return to the original state when the state is loaded.
Is there any way to fix or work around something?

@iflan
Copy link
Contributor

iflan commented Sep 2, 2022

Can you give a particular example? Is this about the state of the drive or about the state of the whole VM?

@dungeonkim
Copy link
Author

Below is the game I am making.
https://www.dungeon.kim/a2rogue/
If you save the state with F6, move around a bit, and then load the state, it doesn't go back to the original state.
I haven't written any files, I'm only reading from the .hdv.

@whscullin
Copy link
Owner

I hadn't implemented saving state for the smart drives because the naive approach of just storing the whole images that is use for floppies doesn't work with the larger disk images, because of browser local storage limitations. But I had been contemplating storing block deltas, and that would work as long as the hdv that gets loaded doesn't change. There are also possibly ways to store more data other than using local storage.

The game you are working on looks great, so I hope we come up a solution that works for you.

@dungeonkim
Copy link
Author

Storing the delta seems like a very good idea.
Thank you very much. Your work helps me a lot. May you always be happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants