Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS2PIP max length inconsistency #147

Closed
daichengxin opened this issue Feb 10, 2025 · 1 comment · Fixed by #169
Closed

MS2PIP max length inconsistency #147

daichengxin opened this issue Feb 10, 2025 · 1 comment · Fixed by #169

Comments

@daichengxin
Copy link

In Koina MS2PIP documents https://koina.wilhelmlab.org/docs#post-/ms2pip_HCD2021/infer, said the model can be applied to any peptide, regardless of digestion enzyme, with lengths between 7 and 40 amino acids. But in this code

def __init__(self, peptide: str, charge: int, maximal_length: int = 30):
, the maximum length of any input is 30

@LLautenbacher
Copy link
Contributor

Thank you for spotting this! The model implementation was done by a different person than the documentation.
I will update the documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants