Makefile: update etcd to latest version, add checksums. (zalando#2783)

* Makefile: update etcd to latest version, add checksums.

Signed-off-by: Sepehrdad Sh <[email protected]>

Author: sepehrdaddev

Makefile

@@ -1,10 +1,11 @@
-SOURCES            = $(shell find . -name '*.go' -and -not -path "./_test_plugins" -and -not -path "./_test_plugins_fail" )
-PACKAGES           = $(shell go list ./...)
-CURRENT_VERSION    = $(shell git describe --tags --always --dirty)
-VERSION           ?= $(CURRENT_VERSION)
-COMMIT_HASH        = $(shell git rev-parse --short HEAD)
-LIMIT_FDS          = $(shell ulimit -n)
-TEST_ETCD_VERSION ?= v2.3.8
+SOURCES             = $(shell find . -name '*.go' -and -not -path "./_test_plugins" -and -not -path "./_test_plugins_fail" )
+PACKAGES            = $(shell go list ./...)
+CURRENT_VERSION     = $(shell git describe --tags --always --dirty)
+VERSION            ?= $(CURRENT_VERSION)
+COMMIT_HASH         = $(shell git rev-parse --short HEAD)
+LIMIT_FDS           = $(shell ulimit -n)
+TEST_ETCD_VERSION  ?= v3.5.11
+TEST_ETCD_CHECKSUM ?= 4fb304f384dd4d6e491e405fed8375a09ea1c6c2596b93f97cb31844202e620df160f87f18611e84f17675e7b7245e40d1aa23571ecdb507cb094ba04d378171
 TEST_PLUGINS       = _test_plugins/filter_noop.so \
 		     _test_plugins/predicate_match_none.so \
 		     _test_plugins/dataclient_noop.so \
@@ -114,7 +115,7 @@ clean: ## clean temporary files and directories
 .PHONY: deps
 deps: ## install dependencies to run everything
 	go env
-	./etcd/install.sh $(TEST_ETCD_VERSION)
+	./etcd/install.sh $(TEST_ETCD_VERSION) $(TEST_ETCD_CHECKSUM)
 	@go install honnef.co/go/tools/cmd/staticcheck@latest
 	@go install github.com/securego/gosec/v2/cmd/gosec@latest
 	@go install golang.org/x/vuln/cmd/govulncheck@latest

etcd/install.sh

@@ -1,22 +1,29 @@
 #! /bin/bash
 set -eo pipefail
 
-ETCD_VERSION=master
-if [  $# -gt 0 ]; then
-    ETCD_VERSION="$1"
+if [ $# -lt 2 ]; then
+    echo "usage: $0 <version> <sha512sum>"
+    exit 1
 fi
 
+ETCD_VERSION="$1"
+ETCD_CHECKSUM="$2"
+ETCD_URL="https://github.com/etcd-io/etcd/releases/download/${ETCD_VERSION}/etcd-${ETCD_VERSION}-linux-amd64.tar.gz"
+
 LOCAL_GOBIN=
+
 if [ -n "${GOBIN}" ]; then
     LOCAL_GOBIN="$GOBIN"
 elif [ -n "${GOPATH}" ]; then
     LOCAL_GOBIN="$GOPATH/bin"
 fi
 
 mkdir -p .bin
-wget \
-    "https://github.com/etcd-io/etcd/releases/download/${ETCD_VERSION}/etcd-${ETCD_VERSION}-linux-amd64.tar.gz" \
-    -O ./.bin/etcd.tar.gz
+
+curl -LsSfo ./.bin/etcd.tar.gz "${ETCD_URL}"
+
+echo "${ETCD_CHECKSUM} ./.bin/etcd.tar.gz" | sha512sum -c
+
 tar -xzf .bin/etcd.tar.gz --strip-components=1 \
     -C ./.bin "etcd-${ETCD_VERSION}-linux-amd64/etcd"