all: remove unused parameters (zalando#2647)

Found via https://github.com/mvdan/unparam/tree/master

Signed-off-by: Alexander Yastrebov <[email protected]>

Author: AlexanderYastrebov

dataclients/kubernetes/kubernetestest/fixtures.go

@@ -61,7 +61,7 @@ func baseNoExt(n string) string {
 
 // iterate over file names, looking for the ones with '.yaml' and '.eskip' extensions
 // and same name, tolerating other files among the fixtures.
-func rangeOverFixtures(t *testing.T, dir string, fs []os.FileInfo, test func(fixtureSet)) {
+func rangeOverFixtures(dir string, fs []os.FileInfo, test func(fixtureSet)) {
 	// sort to ensure that the files belonging together by name are next to each other,
 	// without extension
 	sort.Slice(fs, func(i, j int) bool {
@@ -352,7 +352,7 @@ func FixturesToTest(t *testing.T, dirs ...string) {
 			t.Fatal(err)
 		}
 
-		rangeOverFixtures(t, dir, fs, func(f fixtureSet) {
+		rangeOverFixtures(dir, fs, func(f fixtureSet) {
 			t.Run(f.name, func(t *testing.T) {
 				testFixture(t, f)
 			})

filters/auth/oidc.go

@@ -631,7 +631,7 @@ func (f *tokenOidcFilter) callbackEndpoint(ctx filters.FilterContext) {
 
 			return
 		}
-		oidcIDToken, err = f.getidtoken(ctx, oauth2Token)
+		oidcIDToken, err = f.getidtoken(oauth2Token)
 		if err != nil {
 			if _, ok := err.(*requestError); !ok {
 				ctx.Logger().Errorf("Error while getting id token: %v", err)
@@ -660,7 +660,7 @@ func (f *tokenOidcFilter) callbackEndpoint(ctx filters.FilterContext) {
 			return
 		}
 	case checkOIDCAnyClaims, checkOIDCAllClaims:
-		oidcIDToken, err = f.getidtoken(ctx, oauth2Token)
+		oidcIDToken, err = f.getidtoken(oauth2Token)
 		if err != nil {
 			if _, ok := err.(*requestError); !ok {
 				ctx.Logger().Errorf("Error while getting id token: %v", err)
@@ -880,14 +880,14 @@ func (f *tokenOidcFilter) tokenClaims(ctx filters.FilterContext, oauth2Token *oa
 		return nil, "", requestErrorf("claims do not contain sub")
 	}
 
-	if err = f.handleDistributedClaims(r.Context(), idToken, oauth2Token, tokenMap); err != nil {
+	if err = f.handleDistributedClaims(idToken, oauth2Token, tokenMap); err != nil {
 		return nil, "", requestErrorf("failed to handle distributed claims: %v", err)
 	}
 
 	return tokenMap, sub, nil
 }
 
-func (f *tokenOidcFilter) getidtoken(ctx filters.FilterContext, oauth2Token *oauth2.Token) (string, error) {
+func (f *tokenOidcFilter) getidtoken(oauth2Token *oauth2.Token) (string, error) {
 	rawIDToken, ok := oauth2Token.Extra("id_token").(string)
 	if !ok {
 		return "", requestErrorf("invalid token, no id_token field in oauth2 token")
@@ -966,7 +966,7 @@ func (f *tokenOidcFilter) getTokenWithExchange(state *OauthState, ctx filters.Fi
 //		   }
 //	  }
 //	}
-func (f *tokenOidcFilter) handleDistributedClaims(ctx context.Context, idToken *oidc.IDToken, oauth2Token *oauth2.Token, claimsMap map[string]interface{}) error {
+func (f *tokenOidcFilter) handleDistributedClaims(idToken *oidc.IDToken, oauth2Token *oauth2.Token, claimsMap map[string]interface{}) error {
 	// https://github.com/coreos/go-oidc/issues/171#issuecomment-1044286153
 	var distClaims distributedClaims
 	err := idToken.Claims(&distClaims)

filters/openpolicyagent/openpolicyagent.go

@@ -261,7 +261,7 @@ func (registry *OpenPolicyAgentRegistry) NewOpenPolicyAgentInstance(bundleName s
 	return instance, nil
 }
 
-func (registry *OpenPolicyAgentRegistry) markUnused(inUse map[*OpenPolicyAgentInstance]struct{}) error {
+func (registry *OpenPolicyAgentRegistry) markUnused(inUse map[*OpenPolicyAgentInstance]struct{}) {
 	registry.mu.Lock()
 	defer registry.mu.Unlock()
 
@@ -270,8 +270,6 @@ func (registry *OpenPolicyAgentRegistry) markUnused(inUse map[*OpenPolicyAgentIn
 			registry.lastused[instance] = time.Now()
 		}
 	}
-
-	return nil
 }
 
 func (registry *OpenPolicyAgentRegistry) newOpenPolicyAgentInstance(bundleName string, config OpenPolicyAgentInstanceConfig, filterName string) (*OpenPolicyAgentInstance, error) {

proxy/proxy.go

@@ -805,7 +805,7 @@ func (p *Proxy) lookupRoute(ctx *context) (rt *routing.Route, params map[string]
 	return ctx.routeLookup.Do(ctx.request)
 }
 
-func (p *Proxy) makeUpgradeRequest(ctx *context, req *http.Request) error {
+func (p *Proxy) makeUpgradeRequest(ctx *context, req *http.Request) {
 	backendURL := req.URL
 
 	reverseProxy := httputil.NewSingleHostReverseProxy(backendURL)
@@ -824,7 +824,6 @@ func (p *Proxy) makeUpgradeRequest(ctx *context, req *http.Request) error {
 	upgradeProxy.serveHTTP(ctx.responseWriter, req)
 	ctx.successfulUpgrade = true
 	ctx.Logger().Debugf("finished upgraded protocol %s session", getUpgradeRequest(ctx.request))
-	return nil
 }
 
 func (p *Proxy) makeBackendRequest(ctx *context, requestContext stdlibcontext.Context) (*http.Response, *proxyError) {
@@ -846,9 +845,7 @@ func (p *Proxy) makeBackendRequest(ctx *context, requestContext stdlibcontext.Co
 	}
 
 	if p.experimentalUpgrade && isUpgradeRequest(req) {
-		if err = p.makeUpgradeRequest(ctx, req); err != nil {
-			return nil, &proxyError{err: err}
-		}
+		p.makeUpgradeRequest(ctx, req)
 
 		// We are not owner of the connection anymore.
 		return nil, &proxyError{handled: true}

script/script.go

@@ -340,13 +340,13 @@ func serveRequest(f filters.FilterContext) func(*lua.LState) int {
 			return 1
 		}
 		res := &http.Response{}
-		r.ForEach(serveTableWalk(s, res))
+		r.ForEach(serveTableWalk(res))
 		f.Serve(res)
 		return 0
 	}
 }
 
-func serveTableWalk(s *lua.LState, res *http.Response) func(lua.LValue, lua.LValue) {
+func serveTableWalk(res *http.Response) func(lua.LValue, lua.LValue) {
 	return func(k, v lua.LValue) {
 		sk, ok := k.(lua.LString)
 		if !ok {