-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extra space in fragment #1064
Fix extra space in fragment #1064
Conversation
🦋 Changeset detectedLatest commit: ab31d4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This is PR related to |
If all tests pass, I believe we didn't break existing code. Also, please add a changeset to track the bug fix :) |
@ematipico I think that one just fixed a crash when |
Sorry, I only saw your second message after I wrote my response :) I've added a changeset, hope the wording is acceptable |
All tests pass, so I believe your fix is correct. Worst case scenario can revert it, so it's not a huge deal. Thank you for taking the time to fix the problem |
Changes
hasLeadingSpace
to be true- 1
in line 709 fixes the issue, however I could not find any reason why it was subtracting 1 in the first place. Possible I've missed somethingTesting
Docs
bug fix only