Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attributes using optional chaining not formatting correctly #384

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

Princesseuh
Copy link
Member

Changes

What the title says. We were trying to make spread attributes compatible, but we don't need to because they're already valid JavaScript

Fix #383

Testing

Updated tests to test for more cases

Docs

N/A

Copy link

changeset-bot bot commented Nov 8, 2023

🦋 Changeset detected

Latest commit: 4f39be1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prettier-plugin-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! This syntax probably doesn't do what users expect, but I think it's fine to format.

@Princesseuh Princesseuh merged commit 11b0dc7 into main Nov 8, 2023
5 checks passed
@Princesseuh Princesseuh deleted the fix/format-optional-operator branch November 8, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Error when destructuring with '?' in map loop
2 participants