Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running slowly on Android #154

Open
ColdStar007 opened this issue Dec 4, 2018 · 20 comments · May be fixed by #155
Open

Running slowly on Android #154

ColdStar007 opened this issue Dec 4, 2018 · 20 comments · May be fixed by #155

Comments

@ColdStar007
Copy link

It works fine on iOS, but it runs very slowly on Android.

@minhphung210
Copy link

minhphung210 commented Dec 7, 2018

same issue

@antony-meunier
Copy link

Same here !

@arneson
Copy link

arneson commented Dec 10, 2018

@ColdStar007 @minhphung210 @antony-meunier
There is an infinite loop running in the android version, it has been resolved in a few different forks but there is little to no activity in this repo unfortunately.

You can depend on the tag 1.1.1 in my fork of this repo which has a fix.

https://github.com/arneson/react-native-zss-rich-text-editor.git#1.1.1

@minhphung210
Copy link

@arneson arn
your solution not work for me :(
thank for reply

@arneson
Copy link

arneson commented Dec 12, 2018

That's unfortunate. Have you made sure to do a clean native build before testing? As the problem is in the editor.html file in the library which is only copied over on build, not reload.

@export-mike
Copy link

@arneson keen to make a hard fork? I'm having issues. lets collaborate I have a fork too: https://github.com/export-mike/react-native-zss-rich-text-editor

I'm keen to change this to use the recommended react-native-web-view which is faster for ios and also has window.postMessage working without hacks.

@export-mike
Copy link

@arneson where is the change to remove the infinite loop? https://github.com/arneson/react-native-zss-rich-text-editor/commits/master/src/editor.html

@arneson
Copy link

arneson commented Dec 14, 2018

@export-mike

Yeah, I'd love to get this library working properly again. Would love to collaborate.

It's the commit with message fix getCaretPosition.

arneson@7704a0e#diff-5764eca5893a91bd5fb61afbae89595d

Worth noting is that I did not write that commit but pulled it from charpeni 's fork.

@export-mike
Copy link

ok cool sounds great.

basically the fork of the editor I'm using has the ability to render custom buttons. I need to change it to use the react-native-web-view

I can pull in this infinite loop fix manually. what other changes have you introduced?

what functionality are you working to support/fix?

@arneson
Copy link

arneson commented Dec 14, 2018 via email

@export-mike
Copy link

Yeah great. basically the work I have done so far allows custom components to be rendered.

  • Need to successfully remove the title editor from the editor if not required.
  • Show and hide toolbar successfully on android
  • Android Performance
  • iOS shows a black line page-break kinda thing when scrolling.

@export-mike
Copy link

Bottom 2 points need to be completed.

@arneson
Copy link

arneson commented Dec 17, 2018

@export-mike
Don't think I've seen the last one.
Could you send over a screen shot?

@arneson
Copy link

arneson commented Dec 18, 2018

Saw that link way too late. It’s dead now :) @export-mike

@ethanyuwang
Copy link

@arneson Thanks your fork worked for me!

@ashokkumar88
Copy link

@arneson your version supports hashtag and mentions?

@arneson
Copy link

arneson commented Jan 25, 2019

@ashokkumar88
I have not added that functionality, so if it exists in original package then yes, otherwise no.

@export-mike
Copy link

looks like UIWebView has been deprecated. I'll be updating https://github.com/export-mike/react-native-zss-rich-text-editor to use WKWebView.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants