Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnamed bindpath not respected #8585

Open
1 task done
Emdot opened this issue Jun 21, 2024 · 1 comment · May be fixed by wixtoolset/wix#565
Open
1 task done

Unnamed bindpath not respected #8585

Emdot opened this issue Jun 21, 2024 · 1 comment · May be fixed by wixtoolset/wix#565
Assignees
Labels
Milestone

Comments

@Emdot
Copy link

Emdot commented Jun 21, 2024

WiX Version

5.0.0

.NET or MSBuild or Visual Studio Version

.NET 8.0.300

HeatWave Version

1.0.4.5

Windows Version

Win10 21H2

Repro Repo

No response

Repro Steps

  1. In a wxs file, use Files with Include="**". Example:
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
	<Package Name="MyProduct" Version="1.0.0.0" Manufacturer="Example Corporation" UpgradeCode="{ABCDEFF7-BC0C-4393-ACD8-B2396B5C3564}"		>
                <Files Include="**" />
	</Package>
</Wix>
  1. wix build -bindPath ..\data test.wxs
  2. wix msi decompile test.msi -o test.decompiled.wxs
  3. View the decompiled results

Actual Result

The MSI included files from the source directory

Expected Result

The MSI included files from the directory specified by the -bindpath argument.

The documentation for Files says of **: "If an unnamed bind path was specified, all files in that directory and its subdirectories."

Possibly related:

  • If I use !(bindpath)\**, the build issues a warning warning WIX8601: Missing directory for harvesting files: Could not find a part of the path 'C:\temp\wixtest\code\!(bindpath)'
  • When I use a named bind (-bindPath main=C:\temp\wixtest\data) I get a crash: error WIX0001: System.UnauthorizedAccessException: Access to the path 'C:\Config.Msi' is denied.

Acknowledgements

  • I acknowledge that this is a fully completed bug report. It is not a question or attempt to get help debugging my issue (because those should be sent to Discussions).
@Emdot Emdot added the triage label Jun 21, 2024
@Emdot
Copy link
Author

Emdot commented Jun 24, 2024

Named bindpaths work for me in wixproj files. I don't know what's different about that vs. the command line.

@barnson barnson self-assigned this Aug 20, 2024
@barnson barnson added compiler and removed triage labels Aug 20, 2024
@barnson barnson added this to the v6.0.0-rc.1 milestone Aug 20, 2024
barnson added a commit to wixtoolset/wix that referenced this issue Sep 3, 2024
...harvesting files (as documented).

- Fixes wixtoolset/issues#8585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants