Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to opt out of path validation custom actions in WixUI at build time #8718

Open
barnson opened this issue Aug 27, 2024 · 0 comments · May be fixed by wixtoolset/wix#570
Open

Add ability to opt out of path validation custom actions in WixUI at build time #8718

barnson opened this issue Aug 27, 2024 · 0 comments · May be fixed by wixtoolset/wix#570
Assignees
@barnson
Labels
wip required This issue is complex enough that it requires a WiX Improvement Proposal to be accepted first wip WiX Improvement Proposal wixui
Milestone
v6.0.0-rc.1

Comments

@barnson
Copy link
Member

barnson commented Aug 27, 2024

User story

As a setup developer, I can opt out of the current custom action path validation that occurs in WixUI dialog sets.

Proposal

The current WixUIValidatePath custom action is wired in and opt-out is at runtime using properties. WixUIValidatePath is frequently overkill; the native CheckTargetPath control event is sufficient for most cases---or at least, we should make it possible for users to determine if it's sufficient and not pay the cost of the custom action DLL.

I suppose we should keep WixUIValidatePath by default.

Now that we need a compiler extension, we can more easily manage references.

Considerations

It's worth considering not including WixUIValidatePath by default. Dropping all the custom actions (including WixUIPrintEula) massively simplifies custom dialog sets. (Ironically, it also eliminates the need for a compiler extension...)
@barnson barnson added triage wip WiX Improvement Proposal labels Aug 27, 2024
@barnson barnson changed the title Add ability to opt out of path validation in WixUI Add ability to opt out of path validation in WixUI at build time Aug 27, 2024
@barnson barnson changed the title Add ability to opt out of path validation in WixUI at build time Add ability to opt out of path validation custom actions in WixUI at build time Sep 5, 2024
@barnson barnson self-assigned this Sep 17, 2024
@barnson barnson added wixui wip required This issue is complex enough that it requires a WiX Improvement Proposal to be accepted first and removed triage labels Sep 17, 2024
@barnson barnson added this to the v6.0.0-rc.1 milestone Sep 17, 2024
barnson added a commit to wixtoolset/wix that referenced this issue Sep 28, 2024
@barnson
Drop CA path validation in WixUI by default.
8bf70b9 
Add `WixUI/ExtendedPathValidation="yes"` to opt-in.

Fixes wixtoolset/issues#8718
Relies on #563
@barnson barnson linked a pull request Sep 28, 2024 that will close this issue
Open
barnson added a commit to wixtoolset/wix that referenced this issue Sep 28, 2024
@barnson
Drop CA path validation in WixUI by default.
f8d1a71 
Add `WixUI/ExtendedPathValidation="yes"` to opt-in.
Removed the WIXUI_DONTVALIDATEPATH runtime opt-out.

Fixes wixtoolset/issues#8718
Relies on #563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barnson barnson

Labels
wip required This issue is complex enough that it requires a WiX Improvement Proposal to be accepted first wip WiX Improvement Proposal wixui
Projects
None yet
Milestone
v6.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

Drop CA path validation in WixUI by default. wixtoolset/wix
3 participants
@barnson and others