Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A dummy short file name generated in RemoveFile that might cause a wrong file to be deleted #8832

Open
1 task done
nirbar opened this issue Nov 14, 2024 · 0 comments · May be fixed by wixtoolset/wix#576
Open
1 task done

A dummy short file name generated in RemoveFile that might cause a wrong file to be deleted #8832

nirbar opened this issue Nov 14, 2024 · 0 comments · May be fixed by wixtoolset/wix#576
Assignees
@robmen
Labels
binder
Milestone
v6.0.0-rc.1

Comments

@nirbar
Copy link

nirbar commented Nov 14, 2024

WiX Version

4.x

.NET or MSBuild or Visual Studio Version

VS 2022

HeatWave Version

N/A

Windows Version

10

Repro Repo

No response

Repro Steps

  1. Author a setup project with RemoveFile/@filename="*-file.txt"
  2. View the MSI in orca

Actual Result

A dummy short file name was generated

Expected Result

The FileName column should have the exact FileName attribute authored
Otherwise a different file might get deleted

Acknowledgements

  • I acknowledge that this is a fully completed bug report. It is not a question or attempt to get help debugging my issue (because those should be sent to Discussions).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robmen robmen

Labels
binder
Projects
None yet
Milestone
v6.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

Not generating short file names that might result in wrong file match nirbar/wix4
3 participants
@robmen @barnson @nirbar