Fix internal UI bootstrapper application taskbar icon disappear #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
wixbot
added a commit
to wixtoolset/.github
that referenced
this pull request
Mar 3, 2025
|
If this would fix the issue, it'd be nice to add that information to the commit (it just means the issue will be automatically closed when the PR is merged). I'm pretty sure you can also add it to the PR description for it to do the same (which prevents having to re-write commit history... not that branch commit history is especially sacred). |
robmen
approved these changes
Mar 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As wixtoolset/issues#8135 metion, WixInternalUIBootstrapperApplication cannot show icon on taskbar correctly. Due to the usage of CreateWindowExW in WixToolset.BootstrapperApplications CreateMainWindow, WS_EX_TOOLWINDOW will make the icon disappear in taskbar refer to document. I consider that it is the reason why it cannot show properly.
Fixes wixtoolset/issues#8135