Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible code error in plugins/video/video.py #31

Open
itsayellow opened this issue Nov 26, 2019 · 1 comment
Open

Possible code error in plugins/video/video.py #31

itsayellow opened this issue Nov 26, 2019 · 1 comment

Comments

@itsayellow
Copy link

itsayellow commented Nov 26, 2019

Lines 216-220:

        if ((int(vInfo['vHeight']) >= 720 and
             config.getTivoHeight >= 720) or
            (int(vInfo['vWidth']) >= 1280 and
             config.getTivoWidth >= 1280)):
            data['showingBits'] = '4096'

I believe getTivoHeight and getTivoWidth should be function calls like so:

        if ((int(vInfo['vHeight']) >= 720 and
             config.getTivoHeight(tsn) >= 720) or
            (int(vInfo['vWidth']) >= 1280 and
             config.getTivoWidth(tsn) >= 1280)):
            data['showingBits'] = '4096'
@itsayellow
Copy link
Author

I'm adding another issue in video.py in this Issue because it's concerning the same file.

Line 456:

    def __delitem__(self):

should be:

    def __delitem__(self, key):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant