Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4 support #152

Closed
szado opened this issue Jan 2, 2025 · 3 comments
Closed

PHP 8.4 support #152

szado opened this issue Jan 2, 2025 · 3 comments

Comments

@szado
Copy link

szado commented Jan 2, 2025

It would be nice to see support for PHP 8.4 for this library. Currently PHP emits deprecation warnings as follows:

PHP Deprecated:  Diff\Differ\MapDiffer::__construct(): Implicitly marking parameter $listDiffer as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/diff/diff/src/Differ/MapDiffer.php on line 46

PHP Deprecated:  Diff\Differ\MapDiffer::__construct(): Implicitly marking parameter $comparer as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/diff/diff/src/Differ/MapDiffer.php on line 46

Deprecated: Diff\Differ\ListDiffer::__construct(): Implicitly marking parameter $arrayComparer as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/diff/diff/src/Differ/ListDiffer.php on line 31
@reedy
Copy link
Contributor

reedy commented Jan 3, 2025

126283e fixed these, but a release hasn't been tagged yet.

@reedy
Copy link
Contributor

reedy commented Jan 3, 2025

#146

@codders
Copy link
Contributor

codders commented Jan 6, 2025

Lastest version has been tagged and released - closing this ticket.

@codders codders closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codders @reedy @szado