From 593515be0999703864bb55ecf6c29f9678e006b8 Mon Sep 17 00:00:00 2001 From: Abban Dunne Date: Fri, 13 Dec 2024 12:51:01 +0100 Subject: [PATCH] Implement VAR for C24_WMDE_Mobile_DE_13 VAR has an auto-collapse feature Ticket: https://phabricator.wikimedia.org/T381954 --- .../C24_WMDE_Mobile_DE_13/banner_var.ts | 4 +- .../components/BannerVar.vue | 54 +++- .../components/MinimisedBanner.vue | 20 ++ .../content/MinimisedText.vue | 10 + .../C24_WMDE_Mobile_DE_13/event_map_var.ts | 36 +++ .../styles/BannerVar.scss | 59 +++++ .../styles/MinimisedBanner.scss | 58 ++++ .../styles/styles_var.scss | 30 +++ .../useScrollMinimiser.ts | 21 ++ docs/2025PostCampaignCleanUp.md | 17 ++ package-lock.json | 247 ++---------------- src/components/Icons/InfoIconStraight.vue | 2 +- src/components/Slider/KeenSlider.vue | 4 +- src/themes/Modo/swatches/color_light.scss | 20 +- src/themes/Modo/swatches/skin_default.scss | 2 + .../components/BannerVar.spec.ts | 15 +- test/components/Slider/KeenSlider.spec.ts | 10 + test/features/AutoCollapseMobile.ts | 122 +++++++++ 18 files changed, 478 insertions(+), 253 deletions(-) create mode 100644 banners/mobile/C24_WMDE_Mobile_DE_13/components/MinimisedBanner.vue create mode 100644 banners/mobile/C24_WMDE_Mobile_DE_13/content/MinimisedText.vue create mode 100644 banners/mobile/C24_WMDE_Mobile_DE_13/event_map_var.ts create mode 100644 banners/mobile/C24_WMDE_Mobile_DE_13/styles/BannerVar.scss create mode 100644 banners/mobile/C24_WMDE_Mobile_DE_13/styles/MinimisedBanner.scss create mode 100644 banners/mobile/C24_WMDE_Mobile_DE_13/styles/styles_var.scss create mode 100644 banners/mobile/C24_WMDE_Mobile_DE_13/useScrollMinimiser.ts create mode 100644 test/features/AutoCollapseMobile.ts diff --git a/banners/mobile/C24_WMDE_Mobile_DE_13/banner_var.ts b/banners/mobile/C24_WMDE_Mobile_DE_13/banner_var.ts index 64233ae0a..639e571d3 100644 --- a/banners/mobile/C24_WMDE_Mobile_DE_13/banner_var.ts +++ b/banners/mobile/C24_WMDE_Mobile_DE_13/banner_var.ts @@ -1,6 +1,6 @@ import { createVueApp } from '@src/createVueApp'; -import './styles/styles.scss'; +import './styles/styles_var.scss'; import BannerConductor from '@src/components/BannerConductor/BannerConductor.vue'; import Banner from './components/BannerVar.vue'; @@ -16,7 +16,7 @@ import DynamicTextPlugin from '@src/DynamicTextPlugin'; import { LocalImpressionCount } from '@src/utils/LocalImpressionCount'; import { WindowPageScroller } from '@src/utils/PageScroller/WindowPageScroller'; import { LegacyTrackerWPORG } from '@src/tracking/LegacyTrackerWPORG'; -import eventMappings from './event_map'; +import eventMappings from './event_map_var'; import messages from './messages'; import { LocaleFactoryDe } from '@src/utils/LocaleFactory/LocaleFactoryDe'; import { createFormItems } from './form_items'; diff --git a/banners/mobile/C24_WMDE_Mobile_DE_13/components/BannerVar.vue b/banners/mobile/C24_WMDE_Mobile_DE_13/components/BannerVar.vue index 8b2c17d15..135877e1e 100644 --- a/banners/mobile/C24_WMDE_Mobile_DE_13/components/BannerVar.vue +++ b/banners/mobile/C24_WMDE_Mobile_DE_13/components/BannerVar.vue @@ -1,9 +1,10 @@