-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 최적화 리팩터링 #375
Merged
Merged
refactor: 최적화 리팩터링 #375
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
73f2dfe
refactor: 이미지에 width와 Height 설정
hozzijeong 524e72f
refactor: 검색창에 aria-label 추가
hozzijeong 141865d
design: 에러 페이지 디자인 수정
hozzijeong d4fedb3
test: Calendar에 props 추가
hozzijeong 5ff7a49
refactor: loading 이미지 크기 설정
hozzijeong 053dae3
refactor: 지원하지 않는 파일 제거
hozzijeong 1eaa1d4
chore: msw logout 기능 수정
hozzijeong cfe7a84
refactor: reminder 카드 클릭시 상세보기로 이동
hozzijeong 6e4ca0f
refactor: 테스트를 위한 aria-label 작성
hozzijeong d308f9a
test: reminder cypress 테스트 작성
hozzijeong cc5f7a6
test: 되지 않는 테스트 주석처리
hozzijeong 799c035
feat: 리마인더에 데이터가 없을 경우 바로가기 추가
hozzijeong a86981e
refactor: font missing glyphs 해결
hozzijeong 9e941f3
chore: seo 설정
hozzijeong 3b28506
style: 오타 수정
hozzijeong 9997248
style: html text와 중복되는 aria-label 제거
hozzijeong 71c5c10
refactor: generateSiteMap 위치 수정
hozzijeong 9a30042
chore: 폰트 라이센스 적용 및 이름 변경
hozzijeong 8f0b8ae
feat: 의견 남기기 기능 추가
hozzijeong e83ba30
chore: develop과 merge
hozzijeong 60b27a3
chore: font file name 변경 적용
hozzijeong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
import { convertDateKorYear } from 'utils/date'; | ||
import login from '../utils/login'; | ||
|
||
describe('리마인더 테스트', () => { | ||
beforeEach(() => { | ||
login(); | ||
cy.visit('/reminder'); | ||
}); | ||
|
||
it('리마인더 페이지로 이동할 수 있다.', () => { | ||
cy.visit('/'); | ||
|
||
cy.get('a').contains('리마인더').click().location('pathname').should('equal', '/reminder'); | ||
}); | ||
|
||
it('내 반려 식물 상세보기로 이동할 수 있다.', () => { | ||
cy.get('a[aria-label="참새 나무 상세로 이동"]') | ||
.click() | ||
.location('pathname') | ||
.should('equal', '/pet/1'); | ||
}); | ||
|
||
it('물 주기 등록을 할 수 있다.', () => { | ||
const today = convertDateKorYear(new Date()); | ||
cy.get('div[aria-label="참새 나무의 정보"]') | ||
.find('button[aria-label="물 준 날짜 선택"]') | ||
.click() | ||
.get('div[aria-label="달력"') | ||
.should('be.visible') | ||
.get(`span[aria-label="${today}"]`) | ||
.click() | ||
|
||
.get('#toast-root') | ||
.contains('물주기 완료'); | ||
}); | ||
|
||
it('물 주기 날짜를 다음달 1일로 변경할 수 있다.', () => { | ||
const curMonth = new Date().getMonth(); | ||
const nextMonth = curMonth === 11 ? 1 : curMonth + 2; | ||
cy.get('div[aria-label="참새 나무의 정보"]') | ||
.find('button[aria-label="알림을 줄 날짜 선택"]') | ||
.click() | ||
.get('div[aria-label="달력"') | ||
.should('be.visible') | ||
.get(`button[aria-label="다음 달 보기"]`) | ||
.click() | ||
|
||
.get('section[aria-live="assertive"]') | ||
.find('span') | ||
.contains(1) | ||
.click() | ||
|
||
.get('#toast-root') | ||
.contains('01일로 물주기 날짜 변경') | ||
|
||
.get(`section[aria-label="${Number(nextMonth)}월의 리마인더 정보"]`) | ||
.find('div[aria-label="참새 나무의 정보"]') | ||
.siblings('div[aria-label="01일"]') | ||
.should('be.visible'); | ||
}); | ||
}); |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 폰트 최적화 수작업 👏👏👏👏 멋져요 |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
@font-face { | ||
font-family: 'NanumSquareRound'; | ||
font-weight: 500; | ||
font-style: normal; | ||
font-display: swap; | ||
src: url('/fonts/NanumSquareRoundR2.woff2') format('woff2'); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢 😢 😢 😢 😢