-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: toggle UI/UX #491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hozzijeong
added
๐ ๏ธ ๋ฆฌํฉํฐ๋ง
๋ฆฌํฉํฐ๋ง์ ์ํ ์ด์์
๋๋ค
๐ ํ๋ก ํธ์๋
ํ๋ก ํธ์๋ ๊ด๋ จ ์ด์์
๋๋ค
labels
Jan 11, 2024
Kim0914
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๊ณ ์ํ์ จ์ต๋๋ค !
rawfishthelgh
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํ์ธํ์ต๋๋ค~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
๐ ํ๋ก ํธ์๋
ํ๋ก ํธ์๋ ๊ด๋ จ ์ด์์
๋๋ค
๐ ๏ธ ๋ฆฌํฉํฐ๋ง
๋ฆฌํฉํฐ๋ง์ ์ํ ์ด์์
๋๋ค
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ฅ ์ฐ๊ด ์ด์
๐ ์์ ๋ด์ฉ
Promise.allSetted
๋ผ๋ ๋ฉ์๋๋ฅผ ํตํด ํ๋ฒ์ ์ฒ๋ฆฌํ์ต๋๋ค.๐ฌ ๋ฆฌ๋ทฐ ์ค์ ์ฌํญ
๋ธ๋์น๋ฅผ ํ๊ฒ 2๋ฌ ์ ์ธ๋ฐ ์ด์ ์์ผ PR์ ์์ฑํฉ๋๋ค ใ ์ฌ์ด์ฌ์ด์ ์ผ์ด ์ข ๋ง์์ด์... ใ
์๋ฌ ์ฒ๋ฆฌ ๊ด๋ จ
ํ์ฌ ๊ธฐ์กด ์ฌ์ดํธ์์ ๊ตฌ๋ ํด์ ์์ ์๋์ ๊ฐ์ ๋ฉ์ธ์ง๊ฐ ๋ํ๋๊ณ ์๋๋ฐ, ๋ถํ์ํ ๊ฒ ๊ฐ์์ "๊ตฌ๋ ์ทจ์์ค์ ์๋ฌ๊ฐ ๋ฐ์ํ์ต๋๋ค"๋ก ๋์ฒดํ์ต๋๋ค.
์๋ฌ ์ฒ๋ฆฌ๋ฅผ ํ ๋ response ๋ด๋ถ์ ์๋ ๋ฉ์ธ์ง๋ฅผ ๋ฐ๊ธฐ ์ํด StatusError์
errorResponse
๋ผ๋ ๊ฐ์ฒด๋ฅผ ๊ฐ์ด ๋๊ธธ ์ ์๋๋ก ํ์ต๋๋ค.์ ํฌ๋ ์๋์ ์ผ๋ก ์๋ฒ์์ ์๋ฌ๋ฅผ ๋์ง ๋ response ๋ด๋ถ์ message์ ํํ๋ก ๋์ง๋๋ก ํ๋๋ฐ, response๋ฅผ jsonํํ๋ก ๋ณํํ๊ธฐ ์ ์ ์๋ฌ๋ฅผ throw ํด๋ฒ๋ฆฌ๋๊น ์์ ์๋ ๊ฐ์ ํ์ธํ ์ ์์์ต๋๋ค. ๋ฐ๋ผ์ ํด๋น ์ ๋ฌ๋ฐ์ response ๊ฐ์ฒด๋ฅผ throwํ ๋ ๊ฐ์ด ๋๊ธฐ๊ณ , ํด๋น ์๋ฌ๋ฅผ catch ํ ๊ณณ์์ .json์ผ๋ก ํ์ฑํด์ ํด๋น ๊ฐ์ฒด์ ์ ๊ทผํ ์ ์๋๋ก ์ค์ ํ์ต๋๋ค.
์ด ๋ฐฉ์์ด ๊ณผ์ฐ ์ณ์์ง ํ๋ฒ ๋ด์ฃผ์๋ฉด... ๊ฐ์ฌํ๊ฒ ์ต๋๋ค 40d2625
FCM ๋ก์ง์ Tanstack-Query๋ก ๋ถ๋ฆฌํ ์
๊ธฐ์กด์๋ class๋ก ์บก์ํ ํด์ ๋น๋๊ธฐ ์ฒ๋ฆฌ๋ฅผ ํ๋ ๋ฐฉ์์ผ๋ก ์ฝ๋๋ฅผ ์์ฑํ์์ต๋๋ค. ํ์ง๋ง, ๋น๋๊ธฐ ์ฒ๋ฆฌ ๊ด๋ฆฌ๊ฐ ์ฝ์ง ์์ ๋ฟ๋๋ฌ ์ง๊ด์ ์ด์ง ์๋ค๋ ์๊ฐ์ด ๋ค์๊ณ ํด๋น ๋งค๋ฒ token ๊ฐ์ ์ ์ญ ๊ฐ์ฒด์ ๋ฃ์ด์ผ ํ๋ค๋ ์ ์ด ์ข ๋ถํธํ๊ฒ ๋๊ปด์ก์ต๋๋ค. ๋ฐ๋ผ์ Tanstack-query๋ฅผ ํตํด ์ํ ๊ด๋ฆฌ๋ฅผ ํ ์ ์๊ฒ๋ ์ฝ๋๋ฅผ ๋ณ๊ฒฝํ์ต๋๋ค
ํน์ ์ฝ๋ ๋ณ๊ฒฝ ์ฌํญ์์ ์ด์ํ ์ ์ด ์๋์ง ํ๋ฒ ํ์ธํด์ฃผ์ธ์!!